updating type hint for solutions#9
Open
tnguyen306 wants to merge 6 commits into
Open
Conversation
Owner
|
Quick note, can you add common virtual environment names to the |
branhoff
reviewed
Feb 9, 2023
branhoff
reviewed
Feb 9, 2023
branhoff
reviewed
Feb 9, 2023
branhoff
reviewed
Feb 9, 2023
branhoff
reviewed
Feb 9, 2023
Owner
|
The |
Owner
|
I pointed out a few, but type hints are missing for many of the variables and nearly all of the parameters in the parameter list. |
branhoff
reviewed
Feb 10, 2023
| g = 9.8 # velocity | ||
|
|
||
| return 0.5 * g * t*t | ||
| def fall_distance(t) -> float: |
Owner
There was a problem hiding this comment.
missing type hint on parameter t
Owner
There was a problem hiding this comment.
still missing type hint on parameter t
branhoff
reviewed
Feb 10, 2023
| curr_num = 1 | ||
| sol = 1 | ||
| for i in range(n-1): | ||
| def fib(n) -> int: |
Owner
There was a problem hiding this comment.
missing type hint on parameter n
Owner
There was a problem hiding this comment.
still missing type hint on parameter n
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
| Represents a taxicab that tracks the distance traveled when given x and y coordinates | ||
| """ | ||
| def __init__(self, x, y): | ||
| def __init__(self, x, y) -> None: |
Owner
There was a problem hiding this comment.
missing type hint on x and y parameters
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
reviewed
Feb 10, 2023
branhoff
left a comment
branhoff
left a comment
Owner
There was a problem hiding this comment.
You may want to use mypy: https://www.mypy-lang.org/ to check that your type hinting is correct.
added 2 commits
February 10, 2023 23:48
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
branhoff
reviewed
Feb 16, 2023
| # Description: Mutates a given list and by the order of the elements of teh list | ||
|
|
||
| def reverse_list(lst): | ||
| def reverse_list(lst: any) -> None: |
Owner
There was a problem hiding this comment.
I don't believe any is a type hint. The recommendation I ready is to call object for the Any class. This should be type hinted as list[object]
branhoff
reviewed
Mar 2, 2023
| # Description: Mutates a given list and by the order of the elements of teh list | ||
|
|
||
| def reverse_list(lst): | ||
| def reverse_list(lst: object) -> None: |
Owner
There was a problem hiding this comment.
this is type hinting a parameter named lst of any type. I think you mean lst: list[object]
branhoff
reviewed
Mar 2, 2023
| """ | ||
| temp_lst = [] | ||
| for i in range(len(lst)-1,-1, -1): | ||
| temp_lst: object = [] |
Owner
There was a problem hiding this comment.
Same here. This should be temp_list: list[object] = []
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@branhoff review please